apollo_l1_provider: add anvil to flow test #9871
Conversation
|
This change is |
guy-starkware
force-pushed
the
guyn/l1provider/anvil_in_flow_test
branch
from
752d05e to
7d8c090
Compare
guy-starkware
force-pushed
the
guyn/l1provider/anvil_in_flow_test
branch
from
7d8c090 to
14b0114
Compare
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guy-starkware)
crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):
// Send message from L1 to L2. let l2_contract_address = "0x12";
Extract this to a function
crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):
// Send message from L1 to L2. let l2_contract_address = "0x12";
Move this below the setup
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guy-starkware)
crates/apollo_l1_provider/tests/flow_tests.rs line 70 at r2 (raw file):
assert!(message_timestamp > BlockTimestamp(0)); // Find the L1 event that was posted to Anvil.
Change to // Make sure the L1 event was posted to Anvil
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guy-starkware)
crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):
Previously, ShahakShama wrote…
Extract this to a function
Consider putting into that function the "Find the L1 event that was posted to Anvil"
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guy-starkware)
crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):
Previously, ShahakShama wrote…
Consider putting into that function the "Find the L1 event that was posted to Anvil"
Looks like great minds think alike (#9909)
guy-starkware
left a comment
guy-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ShahakShama)
crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):
Previously, ShahakShama wrote…
Looks like great minds think alike (#9909)
yeah, slowly building it up.
crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):
Previously, ShahakShama wrote…
Move this below the setup
Seems like beautifying something that is going to go away on the next PR is a bit of a waste of time (and unnecessary merge conflicts).
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
guy-starkware
force-pushed
the
guyn/l1provider/anvil_in_flow_test
branch
2 times, most recently
from
a78c5bc to
a820fc0
Compare
guy-starkware
force-pushed
the
guyn/l1provider/flow_test_infrastructure
branch
from
adaba63 to
3ab1d9c
Compare
guy-starkware
force-pushed
the
guyn/l1provider/anvil_in_flow_test
branch
from
a820fc0 to
db35f21
Compare
guy-starkware
force-pushed
the
guyn/l1provider/flow_test_infrastructure
branch
from
3ab1d9c to
10f3241
Compare
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:
guy-starkware
force-pushed
the
guyn/l1provider/anvil_in_flow_test
branch
from
db35f21 to
ba543a6
Compare
guy-starkware
force-pushed
the
guyn/l1provider/flow_test_infrastructure
branch
from
10f3241 to
37d1a84
Compare
guy-starkware
changed the base branch from
guyn/l1provider/flow_test_infrastructure
to
graphite-base/9871
guy-starkware
force-pushed
the
graphite-base/9871
branch
from
37d1a84 to
3d50c46
Compare
guy-starkware
force-pushed
the
guyn/l1provider/anvil_in_flow_test
branch
from
ba543a6 to
3f99e6b
Compare
guy-starkware
changed the base branch from
graphite-base/9871
to
guyn/l1provider/flow_test_infrastructure
guy-starkware
changed the base branch from
guyn/l1provider/flow_test_infrastructure
to
graphite-base/9871
guy-starkware
force-pushed
the
guyn/l1provider/anvil_in_flow_test
branch
from
3f99e6b to
bd42d4e
Compare
guy-starkware
force-pushed
the
graphite-base/9871
branch
from
3d50c46 to
5224365
Compare
guy-starkware
changed the base branch from
graphite-base/9871
to
guyn/l1provider/flow_test_infrastructure
|
Artifacts upload workflows: |
guy-starkware
left a comment
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 3 of 3 files at r5, all commit messages.
Reviewable status:
guy-starkware
changed the base branch from
guyn/l1provider/flow_test_infrastructure
to
main-v0.14.1
guy-starkware
force-pushed
the
guyn/l1provider/anvil_in_flow_test
branch
from
bd42d4e to
97f5c59
Compare
Merge activity
|
No description provided.